lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Jul 2007 10:52:17 +0200 From: Sam Ravnborg <sam@...nborg.org> To: Andi Kleen <andi@...stfloor.org>, Jens Axboe <axboe@...nel.dk>, Andrew Morton <akpm@...l.org>, lkml <linux-kernel@...r.kernel.org>, drbd-user@...ts.linbit.com Subject: Re: [DRIVER SUBMISSION] DRBD wants to go mainline > there is just one logical piece, the drbd module... > it is all in its own subdirectory. For review purposes the split is often file based. Something along the lines of: Makefile + Kconfig include/linux/drdb* <= why 5 files for one module? drdb_main.c drdb_req.{c+h} etc.. So essentially smaller pieces that can be revied but when ready for inclusion it should go in as _one_ commit to avoid breaking bisect. But please finish off all the CodingStyle issue before submission so the review can concentrate on the actual content. Quickly browsing drdb_int.h shows that there are a few issues yet to sort out. typedef usage, funny macros, volatile etc. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists