lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <84144f020707220200od2c6418k4d72996e2e66df3d@mail.gmail.com>
Date:	Sun, 22 Jul 2007 12:00:37 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Andi Kleen" <andi@...stfloor.org>, "Jens Axboe" <axboe@...nel.dk>,
	"Andrew Morton" <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>, drbd-user@...ts.linbit.com
Subject: Re: [DRIVER SUBMISSION] DRBD wants to go mainline

Hi Lars,

On 7/22/07, Lars Ellenberg <lars.ellenberg@...bit.com> wrote:
> there is just one logical piece, the drbd module...
> it is all in its own subdirectory.
> it does not really touch anything else.
> I don't think it is feasible to split it further.

I don't know your code at all but the diffstat suggests that "lru
cache", "worker", "receiver", and "bitmap" could possibly be made
independent patches with all Kconfig and Makefile changes appearing as
a final separate patch (so it's git-bisectable).

This is 17 KLOC of new code. You really want to make it easy to review
if you're serious about getting it merged.

                                   Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ