linux-kernel - Re: [PATCH] dev->priv to netdev_priv(dev), drivers/net/tokenring/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fy3fjfk0.fsf@wanadoo.fr>
Date:	Mon, 23 Jul 2007 17:38:39 +0200
From:	Yoann Padioleau <padator@...adoo.fr>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Yoann Padioleau <padator@...adoo.fr>,
	kernel-janitors@...r.kernel.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dev->priv to netdev_priv(dev), drivers/net/tokenring/

Jan Engelhardt <jengelh@...putergmbh.de> writes:

> On Jul 23 2007 15:18, Yoann Padioleau wrote:
>>
>>Here is an excerpt of the semantic patch that performs the transformation
>>
>>@@
>>
>>- (T*) dev->priv
>>+ netdev_priv(dev)
>
> Note that dev->priv is a void*, and hence does not need casting.
> So dev->priv may also appear without one.

Yes you are right. I have shown only an excerpt of the semantic patch.
Sorry. There is another rule:

@ rule3 depends on rule1 && !rule1bis @
struct net_device *dev;
@@

- dev->priv
+ netdev_priv(dev)


If you look at my patch there is one such case

-	struct tok_info *ti = dev->priv;
+	struct tok_info *ti = netdev_priv(dev);



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/