linux-kernel - Re: [PATCH] update checkpatch.pl to version 0.08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070724115148.GA12799@elte.hu>
Date:	Tue, 24 Jul 2007 13:51:48 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andy Whitcroft <apw@...dowen.org>
Cc:	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	Andrew Morton <akpm@...l.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] update checkpatch.pl to version 0.08

* Ingo Molnar <mingo@...e.hu> wrote:

> what the hell are you thinking? Not every trivial line of code needs 
> to be commented. Comments are needed for the _nontrivial_ lines of 
> code, and there's no way a tool can decide that. [...]

and i thought you understood this point, as earlier versions of 
checkpatch.pl were carefully filtering out _known nontrivial_ code, such 
as the barrier APIs (smp_rmb(), etc.) where we know that they are 
nontrivial in _100%_ of the cases.

trying to warn about code that 'might' be unclean is a catastrophy. This 
tool should only make noise if it is _really_ sure that there's 
something wrong going on. If the tool cannot make an intelligent 
decision about it then it should be silent!

Btw., there's an easy solution for v0.08's many breakages: turn off the 
WARNING output by default and rename it to 'INFO' or something other 
non-alarming.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/