linux-kernel - Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707241456.35769.bjorn.helgaas@hp.com>
Date:	Tue, 24 Jul 2007 14:56:35 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Sébastien Dugué <sebastien.dugue@...l.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console

On Tuesday 24 July 2007 02:40:42 pm Jeff Garzik wrote:
> Please go back and fix the original issue!
> 
> If you are having problems caused by double-probing, the fix is NOT to 
> remove one the probes.  The fix is to ensure use of proper resource 
> reservation, and in some cases, add co-driver-awareness.

Keith Owens did report an issue with the double probe, but I confess
I don't fully understand it.

The real problem was that the serial driver claimed a non-serial
device.  On many laptops, there's an IR device at 0x3e8, IRQ 3.
The serial driver claimed this as ttyS2, using IRQ 4.  So if you
wanted to use the IR device, you had to either:

  - use setserial to make the serial driver forget about ttyS2
    so an IR driver could claim it, or

  - use setserial to change the IRQ to 3 and just use the device
    in SIR mode, which is 16550-compatible so you can use the
    serial driver

I didn't express that very clearly in the changelog.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/