linux-kernel - Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A669AD.6070803@garzik.org>
Date:	Tue, 24 Jul 2007 17:05:49 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Sébastien Dugué 
	<sebastien.dugue@...l.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: commit 7e92b4fc34 - x86, serial: convert legacy COM ports to
 platform devices - broke my serial console

Bjorn Helgaas wrote:
> Keith Owens did report an issue with the double probe, but I confess
> I don't fully understand it.

heh, ok...

> The real problem was that the serial driver claimed a non-serial
> device.  On many laptops, there's an IR device at 0x3e8, IRQ 3.
> The serial driver claimed this as ttyS2, using IRQ 4.  So if you
> wanted to use the IR device, you had to either:
> 
>   - use setserial to make the serial driver forget about ttyS2
>     so an IR driver could claim it, or
> 
>   - use setserial to change the IRQ to 3 and just use the device
>     in SIR mode, which is 16550-compatible so you can use the
>     serial driver
> 
> I didn't express that very clearly in the changelog.

That cannot be a justification for breaking serial port probe that has 
been working for 10+ years.

The VAST MAJORITY of computers, all told, have one or more serial ports 
in the expected places.  We must consider the majority first, then 
tackle edge cases like weirdo laptops that can be detected by other means.

Now that we have established the double-probe problem as potentially 
bogus, and not investigated at all, we are left with:

You changed legacy serial probing, affecting millions of computers, due 
to a few machines with unusual IR configurations.

At this point the "revert! revert!" submarine alarm is sounding quite 
loudly.  You can fix IR without breaking legacy serial.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/