linux-kernel - Re: [PATCH trivial] include linux/mutex.h from scsi_transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A79C00.200@cs.wisc.edu>
Date:	Wed, 25 Jul 2007 13:52:48 -0500
From:	Mike Christie <michaelc@...wisc.edu>
To:	"Michael S. Tsirkin" <mst@....mellanox.co.il>
CC:	James Bottomley <James.Bottomley@...eleye.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi@...r.kernel.org, Roland Dreier <rdreier@...co.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	general@...ts.openfabrics.org
Subject: Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h

Michael S. Tsirkin wrote:
> scsi/scsi_transport_iscsi.h uses struct mutex, so while
> linux/mutex.h seems to be pulled in indirectly
> by one of the headers it includes, the right thing
> is to include linux/mutex.h directly.
> 

Is that part about always including the header directly right? If so 
then were you going to include list.h too, and were you going to fix up 
some of the other iscsi code?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/