linux-kernel - Re: [patch 2.6.23-rc1] dma_free_coherent() needs irqs enabled (sigh)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707241735.55427.david-b@pacbell.net>
Date:	Tue, 24 Jul 2007 17:35:55 -0700
From:	David Brownell <david-b@...bell.net>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	Linux Kernel list <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [patch 2.6.23-rc1] dma_free_coherent() needs irqs enabled (sigh)

On Tuesday 24 July 2007, Russell King wrote:
> > > 
> > > I think you got the year wrong:
> > > 
> > > 5edf71ae (Russell King      2005-11-25 15:52:51 +0000 364)      WARN_ON(irqs_disabled());
> > > 
> > > which is due to this commit:
> > > 
> > > [ARM] Do not call flush_tlb_kernel_range() with IRQs disabled.
> > 
> > This little "to do" list item has been sitting in my mailbox way
> > too long then.  Certainly since it was fair to say "last year"!  ;)
> 
> Are you intentionally not reading what I said?

Hardly.  Go back and read what *I* wrote!

It just took a while to notice that behavioral change, since
I don't normally run the relevant regression tests using lockdep.
It was sometime in the first half of 2006, ergo "since it was
fair to say 'last year'".

A bunch of piecemeal workarounds followed; and recently they were
all replaced with a more fundamental fix.  This doc patch was the
tail end of the process of recovering from that change ... and the
warnings are there to help other folk from seeing the same issue
in other contexts.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/