linux-kernel - Re: wrong constraints "=g" at include/asm-i386/string.h, line 186?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <824323160707261945n2e625beal486c7b1cfe91e01c@mail.gmail.com>
Date:	Fri, 27 Jul 2007 10:45:00 +0800
From:	"Jian-Xin Lai" <laijx03@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: wrong constraints "=g" at include/asm-i386/string.h, line 186?

But as we know, the kerword 'register' is only a suggestion. The
language specification does not force to put the 'register' variable
into a register.
Putting the variable onto stack does not violate anything, but the
assembler will fail.
I think the hack does not really work. THX.

2007/7/26, H. Peter Anvin <hpa@...or.com>:
> Jian-Xin Lai wrote:
> > Hi,
> >
> > The kernel version is 2.6.20.7. In include/asm-i386/string.h, line 169~185:
> > static inline char * strrchr(const char * s, int c)
> > {
> > int d0, d1;
> > register char * __res;
> > __asm__ __volatile__(
> >        "movb %%al,%%ah\n"
> >        "1:\tlodsb\n\t"
> >        "cmpb %%ah,%%al\n\t"
> >        "jne 2f\n\t"
> >        "leal -1(%%esi),%0\n"                                    (*)
> >        "2:\ttestb %%al,%%al\n\t"
> >        "jne 1b"
> >        :"=g" (__res), "=&S" (d0), "=&a" (d1)               (**)
> >        :"0" (0),"1" (s),"2" (c)
> >        :"memory");
> > return __res;
> > }
> >
> > The 'lea' instruction needs a register here (*), but "g" (**) means
> > any registers, memory or immediate integer. Is it correct? If the
> > compiler do not place the __res into a register, the compilation will
> > fail. Should it be "r"?
> > Thank you very much.
> >
>
> Yes, it should be "r", and it looks like the author hacked around the
> fact they had the wrong constraints by using the "register" keyword on
> the variable declaration.
>
>        -hpa
>


-- 
Regards,
Lai Jian-Xin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/