linux-kernel - Re: [PATCH] powerpc: Pegasos keyboard detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070726212241.032e9755.akpm@linux-foundation.org>
Date:	Thu, 26 Jul 2007 21:22:41 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Alan Curry <pacman@...world.com>, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH] powerpc: Pegasos keyboard detection

On Fri, 27 Jul 2007 13:00:21 +1000 Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:

> On Thu, 2007-07-26 at 18:48 -0700, Andrew Morton wrote:
> > On Wed, 25 Jul 2007 17:12:45 +1000 Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
> > 
> > > On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wrote:
> > > > As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse controller
> > > > on the PegasosPPC. This is because of a feature/bug in the OF device tree:
> > > > the "device_type" attribute is an empty string instead of "8042" as the
> > > > kernel expects. This patch (against 2.6.22.1) adds a secondary detection
> > > > which looks for a device whose *name* is "8042" if there is no device whose
> > > > *type* is "8042".
> > > > 
> > > > Signed-off-by: Alan Curry <pacman@...ld.std.com>
> > > 
> > > Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> > > 
> > > Note, if there's a volunteer, we could probably turn that code into a
> > > nice table lookup.
> > 
> > Did this get merged, or otherwise fixed?  Even though the code in there has
> > changed quite a bit, it looks to my untrained eye like the fix is still
> > applicable?
> 
> Merged a fixed version:
> 
> f5d834fc34e61f1a40435981062000e5d2b2baa8
> 
> (In linus tree as of now)

I hope so.  Alan's patch looks rather different from what you have now:
fall back to of_find_node_by_name() if of_find_node_by_type() failed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/