[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46AC900E.9090405@redhat.com>
Date: Sun, 29 Jul 2007 21:03:10 +0800
From: Eugene Teo <eteo@...hat.com>
To: Neil Horman <nhorman@...driver.com>
CC: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
jeremy@...p.org, martin.pitt@...ntu.com, wwoods@...hat.com
Subject: Re: [PATCH 0/3] core_pattern: cleaned up repost/continuing post of
core_pattern enhancements
Neil Horman wrote:
> On Sun, Jul 29, 2007 at 06:40:43PM +0800, Eugene Teo wrote:
>> Neil Horman wrote:
[...]
>> You may want to improve your patches with style-related changes, including
>> removing trailing spaces, using tabs instead of spaces, and defining pointers
>> like char *ptr instead of char * ptr.
>>
> I assume this is just a general comment, since as far as I can see, I've
> followed those guidelines.
Please see the next few emails.
>> Also, it is probably good to think how we can "drop privileges" while piping
>> the core dump output to an external program. A malicious user can potentially
>> use it as a possible backdoor since anything that is executed by "|program" will
>> be executed with root privileges.
>>
> It was my understanding that apport already did this.
I haven't looked at apport yet, but are you talking about the userspace portion of
apport or the kernel changes in the Ubuntu kernel?
Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists