lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070730102850.GA13683@skynet.ie>
Date:	Mon, 30 Jul 2007 11:28:50 +0100
From:	mel@...net.ie (Mel Gorman)
To:	Adrian Bunk <bunk@...sta.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] mm/page_alloc.c: make code static

On (29/07/07 16:58), Adrian Bunk didst pronounce:
> This patch makes needlessly global code static.
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
> 

Seems fair.

Acked-by: Mel Gorman <mel@....ul.ie>

> ---
> 
>  mm/page_alloc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.23-rc1-mm1/mm/page_alloc.c.old	2007-07-26 15:09:24.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/mm/page_alloc.c	2007-07-26 15:11:16.000000000 +0200
> @@ -142,7 +142,7 @@
>    static unsigned long __meminitdata node_boundary_end_pfn[MAX_NUMNODES];
>  #endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */
>    unsigned long __initdata required_kernelcore;
> -  unsigned long __initdata required_movablecore;
> +  static unsigned long __initdata required_movablecore;
>    unsigned long __meminitdata zone_movable_pfn[MAX_NUMNODES];
>  
>    /* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */
> @@ -3686,7 +3686,7 @@
>  	return max_pfn;
>  }
>  
> -unsigned long __init early_calculate_totalpages(void)
> +static unsigned long __init early_calculate_totalpages(void)
>  {
>  	int i;
>  	unsigned long totalpages = 0;

-- 
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ