linux-kernel - Re: [PATCH] fs/partitions/check.c: add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070730123045.4a3f859c@gondolin.boeblingen.de.ibm.com>
Date:	Mon, 30 Jul 2007 12:30:45 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Eugene Teo <eugeneteo@...nel.sg>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes
 (take 2)

On Mon, 30 Jul 2007 17:47:55 +0800,
Eugene Teo <eugeneteo@...nel.sg> wrote:

> +err_out_del_link:
> +	sysfs_remove_link(&p->kobj, "subsystem");
> +err_out_del_kobj:
> +	if (!disk->part_uevent_suppress)
> +		kobject_uevent(&p->kobj, KOBJ_REMOVE);
> +	kobject_put(&p->kobj);
> +err_out:
> +	kfree(p);
>  }

No, this is wrong. You need to move the put behind err_out and remove
the kfree. (The release function will take care of p.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/