linux-kernel - Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

Open Source and information security mailing list archives

Message-ID: <46AF2EAA.2080703@linux.vnet.ibm.com>
Date:	Tue, 31 Jul 2007 18:14:26 +0530
From:	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>
To:	YAMAMOTO Takashi <yamamoto@...inux.co.jp>
CC:	balbir@...ux.vnet.ibm.com, a.p.zijlstra@...llo.nl,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	ebiederm@...ssion.com, containers@...ts.osdl.org,
	akpm@...ux-foundation.org, xemul@...nvz.org, menage@...gle.com,
	dhaval@...ux.vnet.ibm.com
Subject: Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

YAMAMOTO Takashi wrote:
>> +	lock_meta_page(page);
>> +	/*
>> +	 * Check if somebody else beat us to allocating the meta_page
>> +	 */
>> +	race_mp = page_get_meta_page(page);
>> +	if (race_mp) {
>> +		kfree(mp);
>> +		mp = race_mp;
>> +		atomic_inc(&mp->ref_cnt);
>> +		res_counter_uncharge(&mem->res, 1);
>> +		goto done;
>> +	}
> 
> i think you need css_put here.

Thats correct. We do need css_put in this path.

Thanks,
Vaidy

> YAMAMOTO Takashi
> _______________________________________________
> Containers mailing list
> Containers@...ts.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives