linux-kernel - Re: [Patch 02/16] Remove unnecessary kmalloc casts from the mips arch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46AF522B.3000606@gmail.com>
Date:	Tue, 31 Jul 2007 17:15:55 +0200
From:	Rene Herman <rene.herman@...il.com>
To:	jack@...keye.stone.uk.eu.org
CC:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [Patch 02/16] Remove unnecessary kmalloc casts from the mips
 arch.

On 07/31/2007 02:53 PM, jack@...keye.stone.uk.eu.org wrote:

> -	desc_base = (u32)kmalloc(entries * sizeof(au1x_ddma_desc_t),
> +	desc_base = kmalloc(entries * sizeof(au1x_ddma_desc_t),

The unnessary bit in kmalloc casts is due to void pointers being assignment 
compatible to other pointer types but in these patches you are also removing 
casts to unsigned long's and they should stay.

I noticed the same in patch 2, 4, 6, 8, 9 and 11 (cursory glance...)

Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/