linux-kernel - Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Jul 2007 21:35:30 +0530 (IST)
From:	Satyam Sharma <satyam@...radead.org>
To:	WANG Cong <xiyou.wangcong@...il.com>
cc:	Christian Borntraeger <borntraeger@...ibm.com>,
	jack@...keye.stone.uk.eu.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci
 subsystem.



On Tue, 31 Jul 2007, WANG Cong wrote:

> On Tue, Jul 31, 2007 at 08:00:12PM +0530, Satyam Sharma wrote:
> > [...]
> >It better not be, else we have a bug already anyway. Pointers are 64-bit
> >on 64-bit archs. [ it turns out res->start is resource_size_t which is
> >set properly as per CONFIG_RESOURCES_64BIT which itself is set properly
> >as per CONFIG_64BIT, so everything is healthy and fine :-) ]
> >
> 
> I agree.
> 
> However, I think using resource_size_t is a bit better than unsigned long,
> so that we don't need to check the defination of it.
> 
> - res->start = (unsigned long)kmalloc(*size, GFP_KERNEL);
> + res->start = (resource_size_t)kmalloc(*size, GFP_KERNEL);
> 
> Is this change OK?

Yes, that would probably be clearer.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/