linux-kernel - Re: [Patch 05/16] Remove unnecessary kmalloc casts in the drivers subdirectory.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Aug 2007 02:53:49 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	jack@...keye.stone.uk.eu.org
CC:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [Patch 05/16] Remove unnecessary kmalloc casts in the drivers
 subdirectory.

jack@...keye.stone.uk.eu.org wrote:
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -2034,7 +2034,7 @@ static int init_dev(struct tty_driver *d
>  	}
>  
>  	if (!*tp_loc) {
> -		tp = (struct ktermios *) kmalloc(sizeof(struct ktermios),
> +		tp = kmalloc(sizeof(struct ktermios),
>  						GFP_KERNEL);
>  		if (!tp)
>  			goto free_mem_out;
> 

Looks like you can pull the "GFP_KERNEL);" into the same line as the
kmalloc.  IMO a cleanup patch shouldn't leave inexplicable linebreaks
and other whitespace strangeness behind.
-- 
Stefan Richter
-=====-=-=== =--- ----=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/