linux-kernel - Re: [PATCH][RESEND] Semi-pointless NULL test in uli526x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070804211455.GC3530@fattire.cabal.ca>
Date:	Sat, 4 Aug 2007 17:14:55 -0400
From:	Kyle McMartin <kyle@...artin.ca>
To:	Jesper Juhl <jesper.juhl@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Valerie Henson <val@....edu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	tulip-users@...ts.sourceforge.net, david@...g.hm,
	Grant Grundler <grundler@...isc-linux.org>,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH][RESEND] Semi-pointless NULL test in uli526x driver

On Sat, Aug 04, 2007 at 08:32:12PM +0200, Jesper Juhl wrote:
> I don't think dev_id can ever actually be NULL, so the whole block 
> inside "if (!dev) {" could probably just go away. But I guess 
> there's a good reason someone put that ULI526X_DBUG() in there - and
> if 'dev_id' /can/ actually be NULL then it's nice to have and in 
> that case this patch actually fixes a possible crash (hence the 
> version number update). 

It *can* be null, in the case of another handler being registered on the
same irq number, passing NULL for the cookie.

Ack. Will apply.

Regards,
	Kyle
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/