linux-kernel - Re: [PATCH][RESEND] Semi-pointless NULL test in uli526x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46B8E2BE.1050408@garzik.org>
Date:	Tue, 07 Aug 2007 17:23:10 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jesper Juhl <jesper.juhl@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Valerie Henson <val@....edu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	tulip-users@...ts.sourceforge.net,
	Kyle McMartin <kyle@...artin.ca>, david@...g.hm,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [PATCH][RESEND] Semi-pointless NULL test in uli526x driver

Jesper Juhl wrote:
> (resending previously submitted patch from 16/7-2007 22:40)
> 
> 
> Hi,
> 
> In drivers/net/tulip/uli526x.c::uli526x_interrupt() there's a test 
> of the function argument 'void *dev_id' against NULL. But that 
> test is pretty pointless, since if ever 'dev_id' is NULL we'll 
> already have crashed inside "netdev_priv(dev)".
> 
> I don't think dev_id can ever actually be NULL, so the whole block 
> inside "if (!dev) {" could probably just go away. But I guess 
> there's a good reason someone put that ULI526X_DBUG() in there - and
> if 'dev_id' /can/ actually be NULL then it's nice to have and in 
> that case this patch actually fixes a possible crash (hence the 
> version number update). 
> So I guess that in this case we should just move the 
> "db = netdev_priv(dev)" assignment past that NULL test. That's what 
> this patch does.
> 
> Found by the Coverity checker.
> Compile tested.
> 
> 
> PS. Please keep me on Cc when replying.
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>

Just remove the dev==NULL test...

Thanks,

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/