linux-kernel - Re: [Patch] panic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 5 Aug 2007 17:35:31 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Jörg Hoffmann <jh2000@...t24.eu>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [Patch] panic.c


On Aug 5 2007 17:28, Jörg Hoffmann wrote:
>Hello everybody,
>(This is the first time i send in a patch, so correct me if Im doing
>something wrong)

See Documentation/SubmittingPatches. (And perhaps, U+0092 should be replaced by
something visible ;-)

>This patch causes the cpu to stop instead of using an endless loop (Im
>not sure if this works with the watchdog so please take a review).
>The idea behind this is to keep the power usage on panicd machines
>(without auto-reboot) low. Another point is in an Virtual Machine
>environment the process of the VM is using 100% of the host-cpu. This
>would stuck other programs or VMs. This patch brings the VM to stop and
>keeps the cpu usage below 1%.
> 
>I have tested the patch in an VM, the only change is mdelay(); to
>cpu_idle(); it doesnt need more libs and should have no special
>depencies to consider.

cpu_idle() uses quite a lot of variables which may be invalid after a panic.

Something similar has been mentioned previously,
http://lkml.org/lkml/2006/6/19/303

>The panic-blink doesnt work further so it might be removed if there is
>no better way.
> 
>Maybe someone has an better idea for this problem
> 

	Jan
--