linux-kernel - Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440708050149u4c0ef4d8j7ea3478b07312525@mail.gmail.com>
Date:	Sun, 5 Aug 2007 01:49:57 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Muli Ben-Yehuda" <muli@...ibm.com>
Cc:	"Andi Kleen" <ak@...e.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>, riku.seppala@...p.net,
	"Andy Whitcroft" <apw@...dowen.org>,
	"Chuck Ebbert" <cebbert@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Jeff Garzik" <jeff@...zik.org>
Subject: Re: [PATCH/RFT] finish i386 and x86-64 sysdata conversion

On 8/5/07, Muli Ben-Yehuda <muli@...ibm.com> wrote:
> This patch finishes the i386 and x86-64 ->sysdata conversion and
> hopefully also fixes Riku's and Andy's observed bugs. It is based on
> Yinghai Lu's and Andy Whitcroft's patches (thanks!) with some changes:
>
> - introduce pci_scan_bus_with_sysdata() and use it instead of
>   pci_scan_bus() where appropriate. pci_scan_bus_with_sysdata() will
>   allocate the sysdata structure and then call pci_scan_bus().
> - always allocate pci_sysdata dynamically. The whole point of this
>   sysdata work is to make it easy to do root-bus specific things
>   (e.g., support PCI domains and IOMMU's). I dislike using a default
>   struct pci_sysdata in some places and a dynamically allocated
>   pci_sysdata elsewhere - the potential for someone indavertantly
>   changing the default structure is too high.
> - this patch only makes the minimal changes necessary, i.e., the NUMA node is
>   always initialized to -1. Patches to do the right thing with regards
>   to the NUMA node can build on top of this (either add a 'node'
>   parameter to pci_scan_bus_with_sysdata() or just update the node
>   when it becomes known).
>
> The patch was compile tested with various configurations (e.g., NUMAQ,
> VISWS) and run-time tested on i386 and x86-64. Unfortunately none of
> my machines exhibited the bugs so caveat emptor.
>
> Andy, could you please see if this fixes the NUMA issues you've seen?
> Riku, does this fix "pci=noacpi" on your laptop?
>
> Comments appreciated. If this looks ok it should go into 2.6.23.
>
> Signed-off-by: Muli Ben-Yehuda <muli@...ibm.com>
> Cc: Yinghai Lu <yhlu.kernel@...il.com>
> Cc: Andi Kleen <ak@...e.de>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Chuck Ebbert <cebbert@...hat.com>,
> Cc: riku.seppala@...p.net
> Cc: Andy Whitcroft <apw@...dowen.org>
> Cc: Jeff Garzik <jeff@...zik.org>
> ---

sounds good.

Can you change
pci_scan_bus_with_sysdata(int busno)
to
pci_scan_bus_on_node(int bus, struct pci_ops *ops, int node)?

pci_scan_bus_with_sysdata(int busno) make me feel that i need feed one
sysdata as on param for it.

I only need to update irq.c and legacy.c in my patch.

YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/