linux-kernel - Re: [2.6.22.2 review 26/84] make timerfd return a u64 and fix the __put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0708072343390.26397@fbirervta.pbzchgretzou.qr>
Date:	Tue, 7 Aug 2007 23:44:58 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Greg KH <gregkh@...e.de>
cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	torvalds@...ux-foundation.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	davi@...ent.com.br, mtk-manpages@....net, davidel@...ilserver.org
Subject: Re: [2.6.22.2 review 26/84] make timerfd return a u64 and fix the
 __put_user


On Aug 7 2007 13:44, Greg KH wrote:
>--- a/fs/timerfd.c
>+++ b/fs/timerfd.c
>@@ -95,7 +95,7 @@ static ssize_t timerfd_read(struct file 
> {
> 	struct timerfd_ctx *ctx = file->private_data;
> 	ssize_t res;
>-	u32 ticks = 0;
>+	u64 ticks = 0;
> 	DECLARE_WAITQUEUE(wait, current);
> 
> 	if (count < sizeof(ticks))
>@@ -130,7 +130,7 @@ static ssize_t timerfd_read(struct file 
> 			 * callback to avoid DoS attacks specifying a very
> 			 * short timer period.
> 			 */
>-			ticks = (u32)
>+			ticks = (u64)
> 				hrtimer_forward(&ctx->tmr,
> 						hrtimer_cb_get_time(&ctx->tmr),
> 						ctx->tintv);

[ Minor: Cast is not strictly required; hrtimer_forward()s result is
autopromoted/demoted to the type of @ticks. ]



	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/