linux-kernel - Re: [PATCH] at91 pm: Compilation fix for at91sam926x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Aug 2007 00:15:28 +0200
From:	"Ulf Samuelsson" <ulf@...el.com>
To:	"Marc Pignat" <marc.pignat@...s.ch>,
	<linux-arm-kernel@...ts.arm.linux.org.uk>
Cc:	<andrew@...people.com>, <trivial@...nel.org>,
	<linux-kernel@...r.kernel.org>,
	"Andy Herzig" <andrew.herzig@....com>
Subject: Re: [PATCH] at91 pm: Compilation fix for at91sam926x


> > +#if defined(CONFIG_ARCH_AT91RM9200)
> >                         at91_sys_write(AT91_SDRAMC_SRR, 1);     /*
> > self-refresh mode */

> Why don't use:
> if (cpu_is_at91rm9200())
> at91_sys_write(AT91_SDRAMC_SRR, 1);

What is the benefit?
Will the optimizer remove the code if the CPU is not the at91rm9200?

Best Regards
Ulf Samuelsson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/