linux-kernel - Re: [PATCH] at91 pm: Compilation fix for at91sam926x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708092019.46167.hjk@linutronix.de>
Date:	Thu, 9 Aug 2007 20:19:46 +0200
From:	Hans-Jürgen Koch <hjk@...utronix.de>
To:	Andy Herzig <andrew.herzig@....com>
Cc:	Marc Pignat <marc.pignat@...s.ch>,
	linux-arm-kernel@...ts.arm.linux.org.uk, andrew@...people.com,
	trivial@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] at91 pm: Compilation fix for at91sam926x

Am Donnerstag 09 August 2007 19:17 schrieb Andy Herzig:
> On Thu, 2007-08-09 at 18:01 +0200, Marc Pignat wrote:
> 
> > > > +#if defined(CONFIG_ARCH_AT91RM9200)
> > > >                         at91_sys_write(AT91_SDRAMC_SRR, 1);     /*
> > > > self-refresh mode */
> > Why don't use:
> > if (cpu_is_at91rm9200())
> > 	at91_sys_write(AT91_SDRAMC_SRR, 1);
> > 
> No reason. That looks good to me.

No, it doesn't look good. It won't compile.

Hans

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/