linux-kernel - Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070810181632.3a491575@the-village.bc.nu>
Date:	Fri, 10 Aug 2007 18:16:32 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Alexey Dobriyan <adobriyan@...ru>,
	axboe@...nel.dk
Subject: Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls

> In that code we could just do a test on valp (i.e. data in struct
> ctl_table).

Or you could pass the struct pointer and subtract the array start

> I just wanted something stupid and simple, so the -mm tree would not
> be full of broken sysctls.

Well I'd like you to not replace one pile of hard to clean up but easy to
locate crap by smearing other hard to fix in one go crap over the kernel.
> 
> At least to my eyes the code doesn't look much worse.  But if you
> want to do something better feel free.

I'll add it to my todo list. But in the meantime I still NAK the change.
I'll try and get a patch sorted but it'll be after the kernel summit for
sure.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/