linux-kernel - Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46BCCAFC.5090107@goop.org>
Date:	Fri, 10 Aug 2007 13:30:52 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
CC:	ak@...e.de, Glauber de Oliveira Costa <glommer@...il.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, lguest@...abs.org,
	linux-kernel@...r.kernel.org, chrisw@...s-sol.org,
	anthony@...emonkey.ws, Steven@...p2.linux-foundation.org,
	akpm@...ux-foundation.org,
	virtualization@...ts.linux-foundation.org, mingo@...e.hu
Subject: Re: [PATCH 23/25] [PATCH] paravirt hooks for arch initialization

Glauber de Oliveira Costa wrote:
> Indeed, as the EBDA_ADDR_POINTER is not aligned, this may work even
> better.
>
> It seems to me safe to assume that if we read zero on that line:
>
> ebda_addr = *(unsigned short *)__va(EBDA_ADDR_POINTER);
>
> We could just do ebda_size = 0 and go home happy, skipping the rest of
> the process.

Sure, but it should use probe_kernel_addr as well, just so that it will
be robust against having that page unmapped too.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/