lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46BE804A.8080609@gmail.com>
Date:	Sun, 12 Aug 2007 05:36:42 +0200
From:	Rene Herman <rene.herman@...il.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	Jesper Juhl <jesper.juhl@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: Are we properly prepared to handle 3 Socket setups?

On 08/12/2007 05:29 AM, Roland Dreier wrote:

>  >         /*
>  >          * Maximum threshold is 125
>  >          */
>  >         threshold = min(125, threshold);
>  > 
>  > as either the comment or the code is wrong and it seems it's the
>  > code.
> 
> What's the problem?  That line sets threshold to the smaller of the
> current value or 125, which is exactly what one would want to do if
> the maximum value is 125.  Just do a couple of examples: eg if threshold
> is 100 going into that line, then the value is left alone; if
> threshold is 150 then it gets set to 125; and that seems exactly correct.

Crap, need bed, sorry (the fls/ilog2 things still stand -- quite possibly 
both not a problem either).

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ