linux-kernel - Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0708160927s625fd5ax84cd6d12a693d9ad@mail.gmail.com>
Date:	Thu, 16 Aug 2007 12:27:05 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Jeff Garzik" <jeff@...zik.org>
Cc:	"Sonic Zhang" <sonic.adi@...il.com>,
	"Linux IDE" <linux-ide@...r.kernel.org>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	"Bryan Wu" <bryan.wu@...log.com>
Subject: Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

On 8/16/07, Jeff Garzik <jeff@...zik.org> wrote:
> Sonic Zhang wrote:
> > +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev)
> > +{
> > +     int mode = adev->pio_mode - XFER_PIO_0;
> > +     unsigned long base = (unsigned long)ap->ioaddr.ctl_addr;
>
>
> (added Bryan Wu to CC)
>
> Someone needs to need fix the bfin architecture:  the addresses on the
> bfin_read/bfin_write functions should be 'void __iomem *' not unsigned long.

there are no address pointers anymore, so there is nothing to cast ...
the bfin_read/bfin_write macros are done in sexy asm:
#define bfin_write8(addr,val) __asm__ __volatile__("b[%0] = %1;" ::
"a"(addr), "d"(val))
or i'm misunderstanding what you mean ...

where do you see (unsigned long) ?
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/