linux-kernel - Re: [PATCH] s390 appldata_base: Remove module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1187866866.6599.6.camel@localhost>
Date:	Thu, 23 Aug 2007 13:01:06 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Satyam Sharma <satyam@...radead.org>
Cc:	Gerald Schaefer <gerald.schaefer@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] s390 appldata_base: Remove module_exit function and
	modular stuff

On Thu, 2007-08-23 at 07:51 +0530, Satyam Sharma wrote: 
> > BTW the __exit module_exit function appldata_exit() of this driver
> > fails to unregister_hotcpu_notifier() the notifier_block that was
> > registered by appldata_init() during module startup. This will lead
> > to oops if hotplug notification comes after module has been unloaded.
> > Let's fix this by unregistering the notifier appropriately (before
> > appldata_offline_cpu()'ing the CPUs).
> 
> Heh, no wonder we never saw this oops before. This code can never be
> built as a module! :-) But why does it define and implement an __exit
> marked module_exit(appldata_exit) function in that case ?!

I has been a module once for debugging purposes That the module_exit
function still exists is "historical". We can remove it since it is dead
code.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/