linux-kernel - Re: [uml-devel] [PATCH 6/6] UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708231655.00034.blaisorblade@yahoo.it>
Date:	Thu, 23 Aug 2007 16:54:59 +0200
From:	Blaisorblade <blaisorblade@...oo.it>
To:	user-mode-linux-devel@...ts.sourceforge.net
Cc:	Satyam Sharma <satyam@...radead.org>,
	Jeff Dike <jdike@...toit.com>, Andrew Morton <akpm@...l.org>,
	Joe Perches <joe@...ches.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style

On sabato 18 agosto 2007, Satyam Sharma wrote:
> On Fri, 17 Aug 2007, Jeff Dike wrote:
> > Style fixes in hostfs.

> > @@ -328,17 +326,17 @@ int hostfs_readdir(struct file *file, vo
> > [...]
> > -		if(error) break;
> > +		if (error) break;
>
> 		if (error)
> 			break;
>
> > @@ -522,28 +523,28 @@ static int init_inode(struct inode *inod
> > [...]
> >  	else type = OS_TYPE_DIR;
>
> I wonder what's the generally accepted / followed coding style for this,
> actually. Personally I'd prefer:
>
> 	else
> 		type = OS_TYPE_DIR;

I strongly agree with this style; beyond style itself, one strong reason is 
that joining statements hinder singlestepping through function code (it's 
easy to run gdb on UML, and anyway kgdb exists).

Bye
-- 
"Doh!" (cit.), I've made another mistake!
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

Download attachment "signature.asc " of type "application/pgp-signature" (190 bytes)