[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070824152127.GA7190@c2.user-mode-linux.org>
Date: Fri, 24 Aug 2007 11:21:27 -0400
From: Jeff Dike <jdike@...toit.com>
To: Blaisorblade <blaisorblade@...oo.it>
Cc: user-mode-linux-devel@...ts.sourceforge.net,
Satyam Sharma <satyam@...radead.org>,
Jeff Dike <jdike@...toit.com>, Andrew Morton <akpm@...l.org>,
Joe Perches <joe@...ches.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote:
> > actually. Personally I'd prefer:
> >
> > else
> > type = OS_TYPE_DIR;
>
> I strongly agree with this style; beyond style itself, one strong reason is
> that joining statements hinder singlestepping through function code (it's
> easy to run gdb on UML, and anyway kgdb exists).
How does that help? gdb should stop as easily on a "else foo;" line as on
else
foo;
right?
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists