linux-kernel - Re: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708241141.06358.vda.linux@googlemail.com>
Date:	Fri, 24 Aug 2007 11:41:06 +0100
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	Jesper Juhl <jesper.juhl@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c

On Friday 24 August 2007 00:52, Jesper Juhl wrote:
> kmalloc() returns a void pointer.
> No need to cast it.

> -	msp_flash = (struct mtd_info **)kmalloc(
> -			fcnt * sizeof(struct map_info *), GFP_KERNEL);
> -	msp_parts = (struct mtd_partition **)kmalloc(
> -			fcnt * sizeof(struct mtd_partition *), GFP_KERNEL);
> -	msp_maps = (struct map_info *)kmalloc(
> -			fcnt * sizeof(struct mtd_info), GFP_KERNEL);
> +	msp_flash = kmalloc(fcnt * sizeof(struct map_info *), GFP_KERNEL);
> +	msp_parts = kmalloc(fcnt * sizeof(struct mtd_partition *), GFP_KERNEL);
> +	msp_maps = kmalloc(fcnt * sizeof(struct mtd_info), GFP_KERNEL);
>  	memset(msp_maps, 0, fcnt * sizeof(struct mtd_info));

This one wants kzalloc.

> -		msp_parts[i] = (struct mtd_partition *)kmalloc(
> -			pcnt * sizeof(struct mtd_partition), GFP_KERNEL);
> +		msp_parts[i] = kmalloc(pcnt * sizeof(struct mtd_partition),
> +			GFP_KERNEL);
>  		memset(msp_parts[i], 0, pcnt * sizeof(struct mtd_partition));
>
>  		/* now initialize the devices proper */

Same
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/