linux-kernel - Re: [patch 4/6] SLUB: Avoid touching page struct when freeing to per cpu slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0708240944020.20501@schroedinger.engr.sgi.com>
Date:	Fri, 24 Aug 2007 09:46:39 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 4/6] SLUB: Avoid touching page struct when freeing to
 per cpu slab

On Thu, 23 Aug 2007, Christoph Lameter wrote:

> So we need to also check for -1 if !NUMA
> 
> Signed-off-by: Christoph Lameter <clameter@....com>

Sorry. No we do not need this fix. The patch is fine as is.

In slab_alloc() the slow path is entered if c->lockless is NULL. So it
does not matter for slow path determination that node_match always returns 
1 in the !NUMA case.

c->node only needs to be checked for slow path determination in 
slab_free(). And there the node_match is not called.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/