linux-kernel - Re: [patch 4/6] SLUB: Avoid touching page struct when freeing to per cpu slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0708231229030.14478@schroedinger.engr.sgi.com>
Date:	Thu, 23 Aug 2007 12:30:11 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 4/6] SLUB: Avoid touching page struct when freeing to
 per cpu slab

On Thu, 23 Aug 2007, Peter Zijlstra wrote:

> On Wed, 2007-08-22 at 23:46 -0700, Christoph Lameter wrote:
> > plain text document attachment
> > (0008-SLUB-Avoid-touching-page-struct-when-freeing-to-per.patch)
> > Set c->node to -1 if we allocate from a debug slab instead for SlabDebug
> > which requires access the page struct cacheline.
> 
> this relies on node_match() which will only ever return !1 when
> CONFIG_NUMA

Yup the later cmpxchg patches papered that over for awhile.

So we need to also check for -1 if !NUMA

Signed-off-by: Christoph Lameter <clameter@....com>

---
 mm/slub.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux-2.6.23-rc3-mm1/mm/slub.c
===================================================================
--- linux-2.6.23-rc3-mm1.orig/mm/slub.c	2007-08-23 12:26:55.000000000 -0700
+++ linux-2.6.23-rc3-mm1/mm/slub.c	2007-08-23 12:28:07.000000000 -0700
@@ -1424,8 +1424,10 @@ static void flush_all(struct kmem_cache 
  */
 static inline int node_match(struct kmem_cache_cpu *c, int node)
 {
+	if (node == -1)
+		return 0;
 #ifdef CONFIG_NUMA
-	if (node != -1 && c->node != node)
+	if (c->node != node)
 		return 0;
 #endif
 	return 1;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/