linux-kernel - Re: [2.6 patch] fix export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070824214743.GH30705@stusta.de>
Date:	Fri, 24 Aug 2007 23:47:43 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ram Pai <linuxram@...ibm.com>, Sam Ravnborg <sam@...nborg.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] fix export_report.pl

On Fri, Aug 24, 2007 at 11:36:40PM +0200, Jan Engelhardt wrote:
> 
> On Aug 24 2007 23:04, Adrian Bunk wrote:
> >This patch fixes an annoying bug of export_report.pl missing the usages 
> >of some exports.
> >
> >Signed-off-by: Adrian Bunk <bunk@...nel.org>
> >
> >---
> >
> >This patch has been sent on:
> >- 14 Aug 2007
> >
> >--- a/scripts/export_report.pl
> >+++ b/scripts/export_report.pl
> >@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
> > 			next;
> > 		}
> > 		if ($state eq 2) {
> 
> Perl: == for numbers, eq for strings.
> SH:   == for strings, -eq for numbers.
> PHP:  == for everything.

I don't care whether it compares strings or numbers as long as it 
works...

I'm not the author of this script, and my patch fixes the one annoying  
bug I observed when using it.

Feel free to improve the script, but that's unrelated to my bugfix.

> >-			if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
> >+			if ( $_ !~ /0x[0-9a-f]+,/ ) {
> 
> I have not looked closer at it, but this looks like it should be
> /0x[0-9a-fA-F]+,/  or
> /0x[0-9a-f]+,/i
>...

You should have looked closer before sending your email.

> 	Jan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/