lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Aug 2007 14:50:11 -0700 From: "Nelson, Shannon" <shannon.nelson@...el.com> To: "Randy Dunlap" <randy.dunlap@...cle.com> Cc: <akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>, <davem@...emloft.net> Subject: RE: [PATCH v2 -mm 7/7] I/OAT: Add DCA services Randy Dunlap [mailto:randy.dunlap@...cle.com] > >On Thu, 23 Aug 2007 17:15:27 -0700 Shannon Nelson wrote: > [...] >> + >> +/* THIS STUFF NEEDS TO LIVE SOMEWHERE ELSE */ >> +#define X86_FEATURE_DCA (4*32+18) /* Direct Cache Access */ >> +/* / THIS STUFF NEEDS TO LIVE SOMEWHERE ELSE */ > >Yes, feature bits need to be integrated with the other CPU-specific >feature bits. Added to include/asm-i386/cpufeature.h, which is also used by the x86_64 version. > >> +/* pack PCI B/D/F into a u16 */ >> +static inline u16 dcaid_from_pcidev(struct pci_dev *pci) >> +{ >> + return (pci->bus->number << 8) | pci->devfn; >> +} > >Could any other PCI users use this in include/linux/pci.h ? Possibly, but I don't know pci well enough to know for sure, so I'll let someone else jmp in here. > > >> diff --git a/drivers/dma/ioatdma.h b/drivers/dma/ioatdma.h >> index 5931e56..d59c90b 100644 >> --- a/drivers/dma/ioatdma.h >> +++ b/drivers/dma/ioatdma.h >> @@ -132,9 +132,11 @@ struct ioat_desc_sw { >> #if defined(CONFIG_INTEL_IOATDMA) || >defined(CONFIG_INTEL_IOATDMA_MODULE) >> struct ioatdma_device *ioat_dma_probe(struct pci_dev *, >void __iomem *); >> void ioat_dma_remove(struct ioatdma_device *device); >> +struct dca_provider *ioat_dca_init(struct pci_dev *, void >__iomem *); > >Parameter (variable) names in prototypes, please. Done. Thanks again, sln -- ====================================================================== Mr. Shannon Nelson LAN Access Division, Intel Corp. Shannon.Nelson@...el.com I don't speak for Intel (503) 712-7659 Parents can't afford to be squeamish. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists