linux-kernel - Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070830111746.GS14130@parisc-linux.org>
Date:	Thu, 30 Aug 2007 05:17:47 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	andre@...ow14.de
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	rmk@....linux.org.uk
Subject: Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition

On Thu, Aug 30, 2007 at 12:40:38PM +0200, andre@...ow14.de wrote:
> -		diff_int = my_abs(rate_ext-rate);
> -		diff_ext = my_abs(rate_int-rate);
> +		diff_int = abs(rate_ext-rate);
> +		diff_ext = abs(rate_int-rate);

Nothing to do with the patch, but is this really correct?  Surely it
should be diff_ext = abs(rate_ext-rate) ?

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/