linux-kernel - Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070830115059.GA17168@ahaupt-debian-vm.localdomain>
Date:	Thu, 30 Aug 2007 13:50:59 +0200
From:	Andre Haupt <andre@...ow14.de>
To:	Matthew Wilcox <matthew@....cx>
Cc:	andre@...ow14.de, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, rmk@....linux.org.uk
Subject: Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition

On Thu, Aug 30, 2007 at 05:17:47AM -0600, Matthew Wilcox wrote:
> On Thu, Aug 30, 2007 at 12:40:38PM +0200, andre@...ow14.de wrote:
> > -		diff_int = my_abs(rate_ext-rate);
> > -		diff_ext = my_abs(rate_int-rate);
> > +		diff_int = abs(rate_ext-rate);
> > +		diff_ext = abs(rate_int-rate);
> 
> Nothing to do with the patch, but is this really correct?  Surely it
> should be diff_ext = abs(rate_ext-rate) ?

hmmh, not sure about this ...

Russell?


regards,

Andre
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/