linux-kernel - Re: [PATCH] drivers/firmware: const-ify DMI API and internals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0709020249190.20781@enigma.security.iitk.ac.in>
Date:	Sun, 2 Sep 2007 02:51:53 +0530 (IST)
From:	Satyam Sharma <satyam@...radead.org>
To:	Andi Kleen <ak@...e.de>
cc:	Jeff Garzik <jeff@...zik.org>, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <greg@...ah.com>, len.brown@...el.com,
	linux-ide@...r.kernel.org, dz@...ian.org, minyard@....org,
	j.w.r.degoede@....nl, lm-sensors@...sensors.org, rlove@...ve.org,
	bzolnier@...il.com, dmitry.torokhov@...il.com,
	mzxreary@...inter.de, stelian@...ies.net, ibm-acpi@....eng.br,
	ambx1@....rr.com, gimli@...k-green.com
Subject: Re: [PATCH] drivers/firmware: const-ify DMI API and internals

On Sat, 1 Sep 2007, Andi Kleen wrote:
> 
> >     And if we're really lucky, this might enable some additional
> >     optimizations on the part of the compiler.
> 
> Only if the kernel was compiled C++. C compilers generally ignore constness
> for optimization purposes because it can be so easily casted away.

???

I can't speak for the exact const-ification that Jeff did in this
particular patch, but if you intended your comment up there to be a
blanket statement, then you're totally and horribly wrong. There's a
whole plethora of optimizations that gcc does when dealing with const-
marked data. If you've seen / experienced otherwise, please post some
testcases.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/