linux-kernel - Re: [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and internals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070902191746.6aa9fcae@hyperion.delvare>
Date:	Sun, 2 Sep 2007 19:17:46 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, len.brown@...el.com,
	bzolnier@...il.com, minyard@....org, rlove@...ve.org,
	dz@...ian.org, Greg KH <greg@...ah.com>, stelian@...ies.net,
	dmitry.torokhov@...il.com, ibm-acpi@....eng.br, ak@...e.de,
	lm-sensors@...sensors.org, linux-ide@...r.kernel.org,
	mzxreary@...inter.de, j.w.r.degoede@....nl,
	Andrew Morton <akpm@...ux-foundation.org>,
	gimli@...k-green.com, ambx1@....rr.com
Subject: Re: [lm-sensors] [PATCH] drivers/firmware: const-ify DMI API and
 internals

On Sat, 1 Sep 2007 10:27:19 -0400, Jeff Garzik wrote:
> 
> commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4
> Author: Jeff Garzik <jeff@...zik.org>
> Date:   Sat Sep 1 10:16:45 2007 -0400
> 
>     drivers/firmware: const-ify DMI API and internals
>     
>     Three main sets of changes:
>     
>     1) dmi_get_system_info() return value should have been marked const,
>        since callers should not be changing that data.
>     
>     2) const-ify DMI internals, since DMI firmware tables should,
>        whenever possible, be marked const to ensure we never ever write to
>        that data area.
>     
>     3) const-ify DMI API, to enable marking tables const where possible
>        in low-level drivers.
>     
>     And if we're really lucky, this might enable some additional
>     optimizations on the part of the compiler.
>     
>     The bulk of the changes are #2 and #3, which are interrelated.  #1 could
>     have been a separate patch, but it was so small compared to the others,
>     it was easier to roll it into this changeset.
>     
>     Signed-off-by: Jeff Garzik <jeff@...zik.org>

Looks alright to me, thanks Jeff.

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/