lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0709030849260.4454@fbirervta.pbzchgretzou.qr>
Date:	Mon, 3 Sep 2007 08:52:17 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Josef 'Jeff' Sipek <jsipek@...sunysb.edu>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, hch@...radead.org,
	viro@....linux.org.uk, bharata@...ux.vnet.ibm.com,
	j.blunck@...harburg.de, Erez Zadok <ezk@...sunysb.edu>
Subject: Re: [PATCH 09/32] Unionfs: cache-coherency - dentries


On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote:
>@@ -184,10 +183,92 @@ out:
> }
> 
> /*
>+ * Determine if the lower inode objects have changed from below the unionfs
>+ * inode.  Return 1 if changed, 0 otherwise.
>+ */
>+int is_newer_lower(const struct dentry *dentry)

Could use bool and true/false as return value.

>-int __unionfs_d_revalidate_chain(struct dentry *dentry, struct nameidata *nd)
>+int __unionfs_d_revalidate_chain(struct dentry *dentry, struct nameidata *nd,
>+				 int willwrite)

also looks like a bool (willwrite)

>-	if (!__unionfs_d_revalidate_chain(dentry, NULL)) {
>+	if (!__unionfs_d_revalidate_chain(dentry, NULL, 0)) {

(Are there any callers with ,1?)



	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ