linux-kernel - Re: [PATCH] list.h: add list_for_each_entry_continue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1189192192.28781.182.camel@johannes.berg>
Date:	Fri, 07 Sep 2007 21:09:52 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	paulmck@...ux.vnet.ibm.com
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Pavel Emelianov <xemul@...nvz.org>,
	Zach Brown <zach.brown@...cle.com>,
	Dave Jones <davej@...hat.com>, Oleg Nesterov <oleg@...sign.ru>
Subject: Re: [PATCH] list.h: add list_for_each_entry_continue_rcu

On Fri, 2007-09-07 at 08:34 -0700, Paul E. McKenney wrote:

> > + * Continue to iterate over rcu list of given type, continuing after
> > + * the current position.
> 
> Please add something like the following to this comment:
> 
> 	Note that the caller is responsible for making sure that
> 	the element remains in place between the earlier iterator
> 	and this one.  One way to do this is to ensure that
> 	both iterators are covered by the same rcu_read_lock(),
> 	while others involve reference counts, flags, or mutexes.

Sure, will do. Should this comment also be added to
list_for_each_continue_rcu()?

johannes


Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)