linux-kernel - Re: [PATCH 1/2][RESEND] improve generic_file_buffered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070907121525.8a6dd582.randy.dunlap@oracle.com>
Date:	Fri, 7 Sep 2007 12:15:25 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Bernd Schubert <bs@...eap.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2][RESEND] improve generic_file_buffered_write()

On Fri, 7 Sep 2007 20:52:38 +0200 Bernd Schubert wrote:

>  mm/filemap.c |  139 +++++++++++++++++++++++++++++++++----------------
>  1 file changed, 95 insertions(+), 44 deletions(-)
> 
>  
> Index: linux-2.6.23-rc5/mm/filemap.c
> ===================================================================
> --- linux-2.6.23-rc5.orig/mm/filemap.c	2007-09-06 18:33:11.000000000 +0200
> +++ linux-2.6.23-rc5/mm/filemap.c	2007-09-06 18:33:15.000000000 +0200
> @@ -1834,6 +1834,21 @@
>  }
>  EXPORT_SYMBOL(generic_file_direct_write);
>  

The kernel-doc still needs fixes as indicated below:

> +/**
> + * generic_file_buffered_write - handle iov'ectors
> + * @iob:	file operations

s/iob/iocb/

> + * @iov:	vector of data to write
> + * @nr_segs:	number of iov segments
> + * @pos:	position in the file
> + * @ppos:	position in the file after this function
> + * @count:	number of bytes to write
> + * written:	offset in iov->base (data to skip on write)

s/written/@...tten/

> + *
> + * This function will do 3 main tasks for each iov:
> + * - prepare a write
> + * - copy the data from iov into a new page
> + * - commit this page
> + */
>  ssize_t
>  generic_file_buffered_write(struct kiocb *iocb, const struct iovec *iov,
>  		unsigned long nr_segs, loff_t pos, loff_t *ppos,

Thanks.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/