linux-kernel - Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as a module. Works as a module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46EC2BBB.1030506@free.fr>
Date:	Sat, 15 Sep 2007 21:00:11 +0200
From:	Eric Valette <eric.valette@...e.fr>
To:	"Paul Rolland (ポール・ロラン)" 
	<rol@...be.net>
Cc:	Rob Hussey <robjhussey@...il.com>, flamingice@...rmilk.net,
	andreamrl@...cali.it, linux-kernel@...r.kernel.org,
	Johannes Berg <johannes@...solutions.net>
Subject: Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as
 a module. Works as a module.

Paul Rolland (ポール・ロラン) wrote:
> Hi Eric,

>> Now I have two side questions:
>> 	- the code is no more symetric "subsys_initcall" -> "module_exit".
>> Do not know if it is "normal" but I love symmetry in code :-). Did not test
>> it still works as a module...
> Symmetry is not broken, as we have :
> #define subsys_initcall(fn)             module_init(fn)
> in include/linux/init.h where compiling as a module, and when not compiling
> as a module, I doubt the exit function is called unless you are shuting
> down your machine...

I came to this conclusion too. But I would have preferred to have
#define subsys_exit(fn)			modules_exit(fn)

in the case of a module and nop in the non module case...


-- eric





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/