linux-kernel - Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as a module. Works as a module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070915185153.08490a9b@tux.DEF.witbe.net>
Date:	Sat, 15 Sep 2007 18:51:53 +0000
From:	Paul Rolland (ポール・ロラン) <rol@...be.net>
To:	eric.valette@...e.fr
Cc:	Rob Hussey <robjhussey@...il.com>, flamingice@...rmilk.net,
	andreamrl@...cali.it, linux-kernel@...r.kernel.org, rol@...be.net,
	Johannes Berg <johannes@...solutions.net>
Subject: Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used as
 a module. Works as a module.

Hi Eric,

On Sat, 15 Sep 2007 20:30:14 +0200
Eric Valette <eric.valette@...e.fr> wrote:

> Rob Hussey wrote:
> > On 9/15/07, Eric Valette <eric.valette@...e.fr> wrote:
> >> Eric Valette wrote:
> >>
> 
> Thanks for your help: it does indeed fix the problem.
Nice it works for you too !
 
> Now I have two side questions:
> 	- the code is no more symetric "subsys_initcall" -> "module_exit".
> Do not know if it is "normal" but I love symmetry in code :-). Did not test
> it still works as a module...
Symmetry is not broken, as we have :
#define subsys_initcall(fn)             module_init(fn)
in include/linux/init.h where compiling as a module, and when not compiling
as a module, I doubt the exit function is called unless you are shuting
down your machine...

> 	- Who takes the responsability to push a patch to Linus? I guess it
> is urgent unless he plans a rc7
Good point ! I expect the patches to be already in some queue waiting to be
pulled !

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/