[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46EEA6A2.2080001@ichips.intel.com>
Date: Mon, 17 Sep 2007 09:09:06 -0700
From: Sean Hefty <mshefty@...ips.intel.com>
To: Steve Wise <swise@...ngridcomputing.com>
CC: Evgeniy Polyakov <johnpol@....mipt.ru>, netdev@...r.kernel.org,
rdreier@...co.com, general@...ts.openfabrics.org,
linux-kernel@...r.kernel.org
Subject: Re: [ofa-general] Re: [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces
to avoid 4-tuple conflicts.
>>> + addr = kmalloc(sizeof *addr, GFP_KERNEL);
>>
>> As a small nitpick: this wants to be sizeof(struct in_ifaddr)
See chapter 14 of CodingStyle document. kmalloc(sizeof *addr... is correct.
- Sean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists