linux-kernel - RE: [PATCH] Remove an unused variable from the Intel I/OAT DMA engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Sep 2007 09:13:05 -0700
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	"Jesper Juhl" <jesper.juhl@...il.com>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Remove an unused variable from the Intel I/OAT DMA engine driver

 

>-----Original Message-----
>From: Jesper Juhl [mailto:jesper.juhl@...il.com] 
>Sent: Sunday, September 16, 2007 2:32 PM
>To: linux-kernel@...r.kernel.org
>Cc: Nelson, Shannon; Leech, Christopher; Jesper Juhl
>Subject: [PATCH] Remove an unused variable from the Intel 
>I/OAT DMA engine driver
>
>
>The 'u16 chanctrl' variable in 
>drivers/dma/ioatdma.c::ioat_dma_free_chan_resources() is completely 
>unused and gcc quite rightfully warns about it:
>
>  drivers/dma/ioatdma.c:247: warning: unused variable 'chanctrl'
>
>This patch removes the unused variable and silences the warning.
>
>
>Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
>---
>
> ioatdma.c |    1 -
> 1 file changed, 1 deletion(-)
>
>--- linux-2.6/drivers/dma/ioatdma.c~	2007-09-16 
>23:24:20.000000000 +0200
>+++ linux-2.6/drivers/dma/ioatdma.c	2007-09-16 
>23:24:20.000000000 +0200
>@@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources
> 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);
> 	struct ioat_device *ioat_device = to_ioat_device(chan->device);
> 	struct ioat_desc_sw *desc, *_desc;
>-	u16 chanctrl;
> 	int in_use_descs = 0;
> 
> 	ioat_dma_memcpy_cleanup(ioat_chan);
>

Yep, thanks.  That's actually used in an internal version of the driver
and got missed in the stipping.  I'll be sure it is properly taken care
of in the future.

Signed-off-by: Shannon Nelson <shannon.nelson@...el.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/