linux-kernel - Re: [PATCH 001/104] KVM: Fix *nopage() in kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Sep 2007 20:19:23 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Nick Piggin <nickpiggin@...oo.com.au>
CC:	Christoph Hellwig <hch@...radead.org>,
	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Nguyen Anh Quynh <aquynh@...il.com>
Subject: Re: [PATCH 001/104] KVM: Fix *nopage() in kvm_main.c

Nick Piggin wrote:
>>
>> I should mention that the converting to use ->fault() is a 15-minute
>> change; the tricky part is adding backwards compatibility for the
>> external module package.
>>     
>
> It should be mostly possible to ifdef a nopage() handler, which is
> just a wrapper function to translate arguments then call your new
> ->fault() handler. With luck, fault would mostly inline into nopage,
> and do some constant folding to make it cheaper...
>
> I'm planning to go through and convert the rest of the in-tree users
> at some point soon, so if you do get a chance to convert your
> upstream code before I try, it would nice ;)
>
>   

In kvm I don't add compatibility #ifdefs to mainline, instead I have an
awk script that massages the sources into something that all kernels can
grok.

It isn't pretty but it works.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/