lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6599ad830709171121r1ded056j7dc676bb6f37e231@mail.gmail.com>
Date:	Mon, 17 Sep 2007 11:21:35 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add a refcount check in dput()

On 9/15/07, Andrew Morton <akpm@...ux-foundation.org> wrote:
> >
> > +     BUG_ON(!atomic_read(&dentry->d_count));
> >  repeat:
> >       if (atomic_read(&dentry->d_count) == 1)
> >               might_sleep();
>
> eek, much too aggressive.

How about the equivalent BUG_ON() in dget()? I figure that they ought
to both be of the same strictness.

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ