linux-kernel - Re: [PATCH 0/2] unify DMA_..BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46EECC16.10501@goop.org>
Date:	Mon, 17 Sep 2007 11:48:54 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	bbpetkov@...oo.de
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions

Borislav Petkov wrote:
> That is more compact, I agree. However, the XXBIT_MASK macros have the
> better readability, imho. And also, doing 
>
> $grep -Prin 'DMA_..BIT_MASK' * | wc -l
>
> returns 383 on the 23-rc6 tree so removing them should be quite the logistical
> challenge for the kernel janitors :). What do the others think?
>   

Well, even defining the existing macros in terms of DMA_BIT_MASK would
be an improvement.  It's certainly not obvious at first glance that
0x00000007ffffffffULL is a correct 35-bit mask - it's something that the
compiler is perfectly happy to compute for us.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/